Fix: Web3WebSocketProvider deinitialization crash #182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description
When
Web3WebSocketProviderfails to establish a connection during initialization (due to wrong URL or connectivity issues), it properly throws an error as expected. However, when the instance is later deallocated, it crashes with a fatal error:This occurs because:
webSocketproperty is declared as an implicitly unwrapped optional (WebSocket!)webSocketis assigned, it remainsnilFix
Added a nil check before attempting to close the WebSocket connection:
This change ensures the
Web3WebSocketProvidercan be safely deallocated even when a connection couldn't be established, improving error handling and preventing crashes during cleanup.